Feature/inline attachments #137
Open
+273
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- provide functions for detecting inline attachments - implement a fast concatenation of a list of parts to a message - add helper method to separate parts into text/inline/attachment - wrap body and inline attachments in `multipart/related`
This was referenced Oct 22, 2021
|
Hi there, First, thanks for this library. I'm trying this branch, and it works ok; I'm testing it with a set of .eml files, and it is parsed correctly. the only thing that is missing in this PR is the it is a little change though: def get_attachments(%Mail.Message{} = message) do
walk_parts([message], {:cont, []}, fn message, acc ->
case Mail.Message.is_any_attachment?(message) do
true ->
##### THIS
case Mail.Message.get_header(message, :content_disposition) do
["inline", {"filename", filename}] ->
{:cont, List.insert_at(acc, -1, {filename, message.body})}
["attachment", {"filename", filename}] ->
{:cont, List.insert_at(acc, -1, {filename, message.body})}
end
######
false ->
{:cont, acc}
end
end)
|> elem(1)
end |
|
@jarrodmoldrich thank you very much apoligies this went stale. I know it's a bit rediculous to ask after years but if you could just add regression tests for the additional behavior added I can merge this in. |
|
+1 |
|
Sorry, I've been off the radar, but I'm back! I'll have a look at this in the coming weeks. |
|
+1 |
|
@bcardarella Sorry for the delay. Added some tests. Let me know if you think this needs anything else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
For parts with
content-dispostion: inlineits important to reorganize themultipartarrangement in the adapter. In particular it needs to be arrange liked this:My changes reorganize the parts as shown above, while maintaining backwards compatibility. It also adds matching functions for querying for inline attachments as for regular attachments. This change was required for inline images and
.icsfiles to work properly, particularly in Outlook webmail.I've stopped short of adding tests to the test suite, and I'll wait for you to validate my approach first. I duplicated this code for
kalys/bamboo_ses, where it currently functions well for my use cases: kalys/bamboo_ses#43Note: This PR also deprecates #133 as the original order of text parts should be maintained